Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ProactorEventLoop on windows for ipykernel #1184

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

NewUserHa
Copy link
Contributor

On windows ipykernel currently uses SelectorEventLoop which is slower than ProactorEventLoop. this issue causes many apps like vscode use ipykernel slow.

Currently, ipykernel requires python version >=3.8 and tornado version >= 6.1 (which can already work with ProactorEventLoop)

So this issue can be fixed now

related:
tornadoweb/tornado#2608
https://www.tornadoweb.org/en/stable/releases/v6.1.0.html
f40d74a

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, the test suite is about twice as fast, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants